Expansion card questions: Does Moxie’s lasting effect end up giving She-Hulk +2 to each Basic Power because she can change form twice…

I see the interpretation but no, that is not the intention. At its core, Moxie’s ability is two parts: (1) a trigger that responds to a function within the game (in this case, “after you change form”), and (2) a lasting effect that is the outcome of said trigger (+1/+1/+1 until the end of the round). While the duration of the lasting effect is created by the trigger, it does not apply to the trigger itself, only to the basic power increases.